-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-28167: bump Deprecated function removal to 3.8 #6669
Conversation
Also bump PendingDeprecationWarning to DeprecationWarning.
Not sure if requires a News item. If so can a |
Hum, looking at https://bugs.python.org/issue26041 from 2 years ago, it might also be possible to just delete the mention of removal in a future version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the link to the distro package!
Please add a News entry. It's always a good idea to document deprecated features :-) IMHO it would also help to document in What's New in Python 3.7 that platform.linux_distribution() is deprecated and will be removed from Python 3.8. |
Done:
The deprecation was already announced in 3.5 NEWS:
|
GH-6862 is a backport of this pull request to the 3.7 branch. |
Thanks ! |
The distro package is now recommended in Python documentation as a replacement for `platform.linux_distribution`. See: * https://docs.python.org/3.7/library/platform.html#platform.linux_distribution * python/cpython#6669 Also, `platform.linux_distribution` is removed from Python 3.8 (which is not released yet). See: * https://docs.python.org/3.8/library/platform.html * python/cpython#6871 Reflect this in `distro`'s README and docstring.
The distro package is now recommended in Python documentation as a replacement for `platform.linux_distribution`. See: * https://docs.python.org/3.7/library/platform.html#platform.linux_distribution * python/cpython#6669 Also, `platform.linux_distribution` is removed from Python 3.8 (which is not released yet). See: * https://docs.python.org/3.8/library/platform.html * python/cpython#6871 Reflect this in `distro`'s README and docstring.
The distro package is now recommended in Python documentation as a replacement for `platform.linux_distribution`. See: * https://docs.python.org/3.7/library/platform.html#platform.linux_distribution * python/cpython#6669 Also, `platform.linux_distribution` is removed from Python 3.8 (which is not released yet). See: * https://docs.python.org/3.8/library/platform.html * python/cpython#6871 Reflect this in `distro`'s README and docstring.
Also bump PendingDeprecationWarning to DeprecationWarning.
I'm guessing we are far enough in the cycle that it's too late for removal...
https://bugs.python.org/issue28167