-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub suggestions for non-typeshed stubs #14328
Comments
As someone who only learned about I would also want mypy to error out if it detected
|
@hauntsaninja If edit: One change might be to add a CI run with mypy nightly to edit: Another change/test might be to run mypy_primer with pandas-stubs installed and then create issues at pandas-stubs for the reported failures |
A good place for mypy to start would be to check out the stubs list on Also, @twoertwein, |
It seems reasonable to loosen the rules a bit. Perhaps we'd want the stubs to be at least somewhat established, e.g. there would have to be commit activity over N months and we should be able to find some non-trivial projects that are using the stubs. PyPI download stats could also be used as a signal. |
Another idea would be to first provide links to stub packages maintained outside typeshed in the mypy documentation, at least if we are unsure how mature the stubs are. We can then eventually promote stubs to be suggested by mypy if they seem to be sufficiently well-maintained and/or popular. |
Resolves python#14328 Remove the sqlalchemy comment because it's now a PEP 561 package
Resolves #14328 Remove the sqlalchemy comment because it's now a PEP 561 package
Currently mypy only suggests installing stub packages if they're from typeshed. This restriction is important, because package installation can result in arbitrary code execution; potentially automatically when using
--install-types
.However, we can loosen this a little bit. A concrete suggestion is to allow suggestions of stub packages that are under the same Github org as the actual package or maintained by the actual package maintainer. In particular, we've had a couple requests for lxml-stubs and pandas-stubs.
cc @JukkaL
The text was updated successfully, but these errors were encountered: