Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Python 2 support an extra #10183

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Make Python 2 support an extra #10183

merged 2 commits into from
Mar 8, 2021

Conversation

hauntsaninja
Copy link
Collaborator

Resolves #10124

@hauntsaninja hauntsaninja mentioned this pull request Mar 7, 2021
Closed
JukkaL
JukkaL approved these changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. As users update to Python 3.8+, eventually most mypy users won't need to install typed-ast anymore.

@JukkaL JukkaL merged commit 4adb5e4 into python:master Mar 8, 2021
@hauntsaninja hauntsaninja deleted the byebyety branch March 8, 2021 18:50
@freundTech
Copy link
Contributor

I just noticed that this PR adds the python_version<'3.8' environment marker to install_requires, but not to mypy-requirements.txt.

Is this on purpose?

This is inconsistent with the psutil requirement which is also in extras_requires, but is not in mypy-requirements.txt. It is only in test-requirements.txt

@thiagokokada thiagokokada mentioned this pull request Nov 13, 2021
Merged
12 tasks
@e-kwsm e-kwsm mentioned this pull request Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Python 2 support an "extra" in 0.900
3 participants
@hauntsaninja @freundTech @JukkaL