Stop running Python 3.5 in CI #10345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.5 always fails in CI these days Linking python#9950
ethanhs
approved these changes
Apr 20, 2021
|
Agreed. Should we keep the number of compiled suites by making 3.6 compiled? |
|
You probably have a better sense of that than I do — how likely is it that 3.6 compiled will catch issues not caught by 3.7 compiled and 3.6? |
|
I do seem to remember we had a CI false negative once because we didn't have a compiled >= 3.8 (due to some typeshed change to ast), so maybe we make Python 3.9 compiled |
TH3CHARLie
approved these changes
Apr 21, 2021
|
I think that we should run compiled tests on the earliest supported/working Python version and the latest, so it would be 3.6 and 3.9 after this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.5 always fails in CI these days. So a) it's annoying and a bad contributor experience, b) we're effectively not testing against Python 3.5 anyway
Linking #9950