-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement miscellaneous fixes for partially-defined check #14175
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, but there are couple questions about dotted imports.
Good catch on these! Thanks! |
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
@ilevkivskyi I'm going to merge this because I'm pretty sure it's correct now but please take a look at the imports implementation if you get the chance :) I'll send a follow-up PR if something is actually broken. |
These are the issues that I've found using mypy-primer.
You should be able to review this PR commit-by-commit. Each commit includes the relevant tests:
str
and__doc__
)