Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Added new Error to TypedDict #14225

Merged
merged 20 commits into from
Jan 27, 2023
Merged

✨ Added new Error to TypedDict #14225

merged 20 commits into from
Jan 27, 2023

Commits on Nov 30, 2022

  1. ✨ Added new Error to TypedDict 

    See: [python#4617](python#4617)

This allows the following code to trigger the error
`typeddict-unknown-key`

```python
A = T.TypedDict("A", {"x": int})

def f(x: A) -> None:
    ...

f({"x": 1, "y": "foo"})
```

The user can then safely ignore this specific error at their
disgression.
    @JoaquimEsteves
    JoaquimEsteves committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    c7824be View commit details
    Browse the repository at this point in the history

  2. 🐛 Fixed 'missing keys' not being reported

    @JoaquimEsteves
    JoaquimEsteves committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    f19a7f7 View commit details
    Browse the repository at this point in the history

  3. 🐛 Early return in case there's missing or extra keys

    @JoaquimEsteves
    JoaquimEsteves committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    2a4220c View commit details
    Browse the repository at this point in the history

  4. 🧑‍🔬 Fixed simple error-code tests 

    We now return two instead of one
    @JoaquimEsteves
    JoaquimEsteves committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    fcf4909 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Update test-data/unit/check-typeddict.test 

    Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
    @JoaquimEsteves @ilevkivskyi
    JoaquimEsteves and ilevkivskyi authored Dec 2, 2022
    Configuration menu
    Copy the full SHA
    deb6543 View commit details
    Browse the repository at this point in the history

  2. Update test-data/unit/check-errorcodes.test 

    Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
    @JoaquimEsteves @ilevkivskyi
    JoaquimEsteves and ilevkivskyi authored Dec 2, 2022
    Configuration menu
    Copy the full SHA
    222869d View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. ✨ We now typecheck despite having an extra-key 

    🧑‍🔬 Added test to check this behaviour
    @JoaquimEsteves
    JoaquimEsteves committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    70c0a18 View commit details
    Browse the repository at this point in the history

  2. 🧹 Setting an extra value on a TypedDict now has the correct error code

    @JoaquimEsteves
    JoaquimEsteves committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    eda0c8b View commit details
    Browse the repository at this point in the history

  3. ✨ We can now set an item and get the correct error code

    @JoaquimEsteves
    JoaquimEsteves committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    25f3dbc View commit details
    Browse the repository at this point in the history

  4. 🧑‍🔬 Redid the IgnotErrorCodeTypedDictNoteIgnore test

    @JoaquimEsteves
    JoaquimEsteves committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    c7c687f View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. 🐈‍⬛ Black

    @JoaquimEsteves
    JoaquimEsteves committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    a275c86 View commit details
    Browse the repository at this point in the history

  2. 🐛 Added Review Suggestions 

    We don't need to convert dict_keys/items to set.

Also fixed the comment saying literally the opposite of what was
happening
    @JoaquimEsteves
    JoaquimEsteves committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f7a7f4f View commit details
    Browse the repository at this point in the history

  3. 📝 Fixed docstring not being in the correct format.

    @JoaquimEsteves
    JoaquimEsteves committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    06a3866 View commit details
    Browse the repository at this point in the history

  4. 🐛 Fixed ignoring unknown-key not silencing the 'Did you mean' message

    @JoaquimEsteves
    JoaquimEsteves committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    780e10d View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Review Feedback - Better Docstrings 

    Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
    @JoaquimEsteves @ilevkivskyi
    JoaquimEsteves and ilevkivskyi authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    fb98524 View commit details
    Browse the repository at this point in the history

  2. 📝 Added unknown-key to the error_code_list

    @JoaquimEsteves
    JoaquimEsteves committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    708d322 View commit details
    Browse the repository at this point in the history

  3. 🐛 Black and sphinx bugs

    @JoaquimEsteves
    JoaquimEsteves committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e4b82b6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into master

    @JoaquimEsteves
    JoaquimEsteves authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    1c9a623 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into master

    @JoaquimEsteves
    JoaquimEsteves authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    f4f0cd0 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Apply suggestions from code review (docs)

    @ilevkivskyi
    ilevkivskyi authored Jan 25, 2023
    Configuration menu
    Copy the full SHA
    957ba17 View commit details
    Browse the repository at this point in the history