-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mypyc] Precompute set literals for "in" ops against / iteration over set literals #14409
Merged
Commits on Aug 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b0f57ab - Browse repository at this point
Copy the full SHA b0f57abView commit details
Commits on Aug 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c8d2dda - Browse repository at this point
Copy the full SHA c8d2ddaView commit details
Commits on Jan 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 779a598 - Browse repository at this point
Copy the full SHA 779a598View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fabcfe - Browse repository at this point
Copy the full SHA 7fabcfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97faab5 - Browse repository at this point
Copy the full SHA 97faab5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ccf951 - Browse repository at this point
Copy the full SHA 3ccf951View commit details -
Configuration menu - View commit details
-
Copy full SHA for de47fef - Browse repository at this point
Copy the full SHA de47fefView commit details
Commits on Jan 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0036e20 - Browse repository at this point
Copy the full SHA 0036e20View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1527e2 - Browse repository at this point
Copy the full SHA e1527e2View commit details -
Oh look, I found constant_fold_expr()
constant_fold_expr() replaces my custom logic for string/integer literals and final references. It even supports folding constant expressions which means even {1 + 2} could be precomputed! This means final references to bool, float, bytes*, and complex values are no longer supported, but that's okay for now. In a later patch, we can add proper support for (some of) these types to constant_fold_expr(). *Also bytes are just in general really annoying to work with (because the true bytes value isn't stored anywhere, you have to convert the string representation to bytes instead... ugh) so I don't really care about final refs to bytes values/literals right now. Byte literals IN the sets are still supported.
Configuration menu - View commit details
-
Copy full SHA for e3d3045 - Browse repository at this point
Copy the full SHA e3d3045View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d68a7b - Browse repository at this point
Copy the full SHA 8d68a7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b75b7d - Browse repository at this point
Copy the full SHA 1b75b7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a55fa4 - Browse repository at this point
Copy the full SHA 1a55fa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d44293 - Browse repository at this point
Copy the full SHA 3d44293View commit details -
Work around mypyc bug ... attempt 3
I got tired of trying to compile mypy locally (15 minutes and it's still not done), let's see what CI has to say.
Configuration menu - View commit details
-
Copy full SHA for fefac47 - Browse repository at this point
Copy the full SHA fefac47View commit details
Commits on Jan 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9cdfc98 - Browse repository at this point
Copy the full SHA 9cdfc98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f18f30 - Browse repository at this point
Copy the full SHA 2f18f30View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.