Fix internal crash when resolve same partial type twice #14552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
test-data/unit/check-inference.test
Outdated
| arr = [] | ||
| arr.append(arr.append(1)) | ||
| [out] | ||
| main:3: error: "List[int]" has no attribute "append" |
There was a problem hiding this comment.
It's better than a crash (thanks for filing this PR!), but this error still doesn't make sense.
There was a problem hiding this comment.
@JelleZijlstra You are right, that is because I forgot to add fixtures to a test. Fixed, please, review again.
There was a problem hiding this comment.
Thanks! I guess when there's something weird going on in a mypy test there's a 90% chance it's due to a fixture.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
Jan 29, 2023
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Jan 29, 2023
Fixes: python#14548 Fixed case when untyped list item type resolving can lead to an internal crash. Code to reproduce this issue: ```py arr = [] arr.append(arr.append(1)) ``` Basically, the issue is that after the first resolving of `arr.append` method, `var` is deleted from `partial_types`, and as war as `arr.append` is a nested call we try to delete the same `var` that was already deleted.
hauntsaninja
added a commit
that referenced
this pull request
Jan 29, 2023
#14552) (#14553) Fixes: #14548 Fixed case when untyped list item type resolving can lead to an internal crash. Code to reproduce this issue: ```py arr = [] arr.append(arr.append(1)) ``` Basically, the issue is that after the first resolving of `arr.append` method, `var` is deleted from `partial_types`, and as war as `arr.append` is a nested call we try to delete the same `var` that was already deleted. Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14548
Fixed case when untyped list item type resolving can lead to an internal crash.
Code to reproduce this issue:
Basically, the issue is that after the first resolving of
arr.appendmethod,varis deleted frompartial_types, and as war asarr.appendis a nested call we try to delete the samevarthat was already deleted.