Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash on walrus in comprehension at class scope #14556

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

ilevkivskyi
Copy link
Member

Fixes #14201

The fix is trivial, turn an assert condition into a blocker error (with message matching Python syntax error). I also add a test case for a crash from the same issue that looks already fixed.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja hauntsaninja merged commit c4ecd2b into python:master Jan 29, 2023
@ilevkivskyi ilevkivskyi deleted the fix-comp-crash branch January 30, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several crashes on pyright test suite
2 participants