Reduce size of JSON data in Mypy cache #14808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Python outputs spaces after commas and colons when dumping JSON
data. This is normally fine, but when exporting large amounts of JSON (such as
cache info) it is more space efficient to export JSON without whitespaces. To
do this, simply pass `separators=(",", ":")` to `json.dumps()`.
Although the space savings aren't massive, they do reduce the size of the cache
folder by a couple of megabytes:
| Method | Size |
|---------|--------|
| Current | 31.2MB |
| This PR | 29.3MB |
For comparison, the size of the cache folder with the `--sqlite-cache` option
is about 27.5MB.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Python outputs spaces after commas and colons when dumping JSON data. This is normally fine, but when exporting large amounts of JSON (such as cache info) it is more space efficient to export JSON without whitespaces. To do this, simply pass
separators=(",", ":")tojson.dumps().Although the space savings aren't massive, they do reduce the size of the cache folder by a couple of megabytes:
For comparison, the size of the cache folder with the
--sqlite-cacheoption is about 27.5MB.