Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix disappearing errors when re-running dmypy check (#14835)" #15179

Merged
merged 1 commit into from
May 4, 2023

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented May 4, 2023

This reverts commit a9ee618.

The original fix doesn't work in all cases. Reverting it since fixing remaining issues is non-trivial, and it's better not to include regressions or partially implemented features in mypy 1.3. See #9655 for context.

This reverts commit a9ee618.

The original fix doesn't work in all cases. Reverting it since fixing
remaining issues is non-trivial, and it's better not to include regressions
or partially implemented features in mypy 1.3. See #9655 for context.
Copy link
Contributor

@meshy meshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks.

@JukkaL JukkaL merged commit d17b3ed into master May 4, 2023
@JukkaL JukkaL deleted the revert-dmypy-type-ignores branch May 4, 2023 11:46
wesleywright pushed a commit that referenced this pull request May 4, 2023
…#15179)

This reverts commit a9ee618.

The original fix doesn't work in all cases. Reverting it since fixing
remaining issues is non-trivial, and it's better not to include
regressions or partially implemented features in mypy 1.3. See #9655 for
context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants