Fix some TypeVarTuple Callable edge cases. #15254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we mostly only tested substituting in concrete values to Callables (see tests in PR). Now we test in substituting Unpack[Args], etc. Prefices and suffices are not implemented yet because they seem very nontrivial to get working. We also test what happens when the `submit` function in the test case is defined using ParamSpec but we pass in an Unpack through *args, and we fix a crash related to that scenario.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
Superseded by #16198 |
ilevkivskyi
added a commit
that referenced
this pull request
Sep 28, 2023
Supersedes #15254 Note the error message for one of the test is slightly different. Although it _may_ suggest that `Unpack[...]` is a valid type on its own, this error is kind of more consistent with old style `*args: int` annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we mostly only tested substituting in concrete values to Callables (see tests in PR). Now we test in substituting Unpack[Args], etc. Prefices and suffices are not implemented yet because they seem very nontrivial to get working.
We also test what happens when the
submitfunction in the test case is defined using ParamSpec but we pass in an Unpack through *args, and we fix a crash related to that scenario.