[mypyc] Don't explicitly assign NULL values in setup functions
#15379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating something unrelated I stumbled across the `*_setup` functions, and I noticed that they contain a lot of code that looks like this: ```c self->abc = NULL; self->xyz = NULL; // ... ``` Something told me that assigning `NULL` to a bunch of fields is propably not needed, and when looking at the docs for `tp_alloc()` I found this reference to [`allocfunc`](https://docs.python.org/3/c-api/typeobj.html#c.allocfunc), the typedef for `tp_alloc()`: > It should return a pointer to a block of memory of adequate length for the > instance, suitably aligned, **and initialized to zeros**, ... Emphasis is mine. Basically I added a simple check that removes lines similar to above which assigns `NULL` values in setup functions. This removes about ~4100 lines from the C file when self-compiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating something unrelated I stumbled across the
*_setupfunctions, and I noticed that they contain a lot of code that looks like this:Something told me that assigning
NULLto a bunch of fields is propably not needed, and when looking at the docs fortp_alloc()I found this reference toallocfunc, the typedef fortp_alloc():Emphasis is mine.
Basically I added a simple check that removes lines that assigns
NULLvalues in setup functions. This removes about ~4100 lines from the C file when self-compiling.