Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on follow_imports_for_stubs #15407

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

ilevkivskyi
Copy link
Member

Fixes #15246
Likely fixes #15319, but I didn't find a repro.

Note I also cleanup one thing, there should be clear separation:

  • CORE_BUILTIN_MODULES must be always available, and their content must be unaltered, since we rely on it.
  • semanal_main.core_modules should be analyzed first among builtins SCC in a specific order.

mypy/build.py Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit e7b917e into python:master Jun 9, 2023
@ilevkivskyi ilevkivskyi deleted the fix-tp-crash branch June 9, 2023 23:53
jhance pushed a commit that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: '_typeshed' crash in dmypy run Mypy 1.3.0 crashes when using dictionary unpacking
3 participants