Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special casing for "cannot" in error messages #15428

Merged
merged 7 commits into from
Jun 13, 2023

Conversation

ikonst
Copy link
Contributor

@ikonst ikonst commented Jun 13, 2023

Continuing #15365.

hauntsaninja and others added 4 commits June 3, 2023 22:58
This tripped me up the other day when grepping for an error message.
Thanks to ikonst's --update-data improvements, trivial to fix
everywhere.
@ikonst
Copy link
Contributor Author

ikonst commented Jun 13, 2023

This PR intentionally only touches tests. A follow-up PR can change actual messages if we feel "can't" is too informal"

@ikonst
Copy link
Contributor Author

ikonst commented Jun 13, 2023

@JelleZijlstra @hauntsaninja 🚀 ready

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this! Yeah, sorry, have been a little short on time last couple weeks

@hauntsaninja hauntsaninja merged commit 61a7f3b into python:master Jun 13, 2023
@ikonst ikonst deleted the cannot2 branch June 13, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants