Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded --strict-optional flags from test cases #15684

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Remove unneeded --strict-optional flags from test cases #15684

merged 3 commits into from
Jul 17, 2023

Conversation

AlexWaygood
Copy link
Member

Following @cdce8p's excellent work, these are now redundant!

cdce8p
cdce8p approved these changes Jul 16, 2023
View reviewed changes
Copy link
Collaborator

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional cleanup @AlexWaygood! LGTM

@hauntsaninja hauntsaninja merged commit 3f601c3 into python:master Jul 17, 2023
12 checks passed
@AlexWaygood AlexWaygood deleted the remove-strict-optional-flags branch July 17, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @hauntsaninja @cdce8p