LoggerAdapter: the extra property is a simple dict #15713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if not properly documented, the extra property of LoggerAdapter objects is a simple dict and thus can be modified
|
Thanks for the PR! Unfortunately this is vendored code, so this change would just get overwritten in two weeks when we did our next typeshed sync, if we were to merge this. You'll have to make a PR to https://github.com/python/typeshed if you'd like to make changes to this file :) |
|
@AlexWaygood thanks for the quick response! I'll try there |
|
Diff from mypy_primer, showing the effect of this PR on open source code: prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/logging/loggers.py:61: error: Unpacked dict entry 0 has incompatible type "Mapping[str, object] | None"; expected "SupportsKeysAndGetItem[str, object]" [dict-item]
+ src/prefect/logging/loggers.py:61: error: Unpacked dict entry 0 has incompatible type "dict[str, object] | None"; expected "SupportsKeysAndGetItem[str, object]" [dict-item]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if not properly documented, the extra property of LoggerAdapter objects is a simple dict and thus can be modified
This PR simply changes the type of the
extraproperty fromMapping(immutable) todict(mutable)