Stubtest: don't error if a module in a tests/ directory is missing from the stub
#15725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Jul 21, 2023
There was a problem hiding this comment.
On the other hand, this would interfere with our project: https://github.com/typeddjango/django-stubs/tree/master/django-stubs/test
Because, django.test is public, we want stubtest to raise warnings there.
I think it would be better to decide on a project basis.
|
It would still emit errors for modules in But yeah, I guess this is an unreliable heuristic, and should probably be decided per-project :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a quite a few allowlist entries in typeshed at the moment to get stubtest to stop complaining about
tests/directories being missing from the stubs. This PR fixes that.