Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TypeVar refresh uniformly for class object access #15945

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

ilevkivskyi
Copy link
Member

Fixes #15934

I think this is a right thing to do, it may even fix some other rare accidental TypeVar clashes not involving self-types. This causes a bit of churn in tests, but not too much.

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi ilevkivskyi merged commit 9e1f4df into python:master Aug 24, 2023
17 checks passed
@ilevkivskyi ilevkivskyi deleted the fix-self-class-access branch August 24, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My 1.5.1 gets confused when a class variable references a method from another class that returns Self.
2 participants