Revert "Add support for attrs.fields (#15021)"
#15955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 391ed85.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
requested changes
Aug 25, 2023
There was a problem hiding this comment.
Could you be more specific about what the regression is? I fixed the thing that was a blocker for 1.4 and 1.5 in #15688 , maybe I could take a look at attr.has too
|
Ah, I didn't realize there had been a global fix for the issue that affected 1.4 and 1.5. I'll file these as separate issues and link them in the release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 391ed85.
This change was reverted for release 1.5 in #15674, and for 1.4 in 3bf9fdc. This change doesn't work well with
attr.has, since it doesn't recognizeattr.AttrsInstanceas a valid argument forattr.fields.