Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daemon crash caused by deleted submodule #16370

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Oct 30, 2023

If a submodule has been deleted while using a fine-grained cache, the daemon could crash during fixup, since there could be a symbol table entry in a parent package that would appear to refer to itself. Handle the case by adding a placeholder symbol table entry instead. Eventually the parent package will be reprocessed and the symbol table will be completed.

If a submodule has been deleted while using a fine-grained cache,
the daemon could crash during fixup, since there could be a
symbol table entry in a parent package that would appear to
refer to itself. Handle the case by adding a placeholder symbol
table entry instead. Eventually the parent package will be
reprocessed and the symbol table will be completed.
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@svalentin svalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The elusive daemon crashes!

@JukkaL JukkaL merged commit 5624f40 into master Oct 30, 2023
17 of 18 checks passed
@JukkaL JukkaL deleted the daemon-fixup-crash branch October 30, 2023 14:27
JukkaL added a commit that referenced this pull request Nov 9, 2023
The script format changelog entries based on commit history and has some
rules to filter out some changes, such as typeshed sync and changes
cherry-picked to the previous release branch.

Example of how to run it:
```
$ python misc/generate_changelog.py 1.7
Generating changelog for 1.7
Previous release was     1.6
Merge base: d7b2451
NOTE: Drop "Fix crash on ParamSpec unification (for real)", since it was in previous release branch
NOTE: Drop "Fix crash on ParamSpec unification", since it was in previous release branch
NOTE: Drop "Fix mypyc regression with pretty", since it was in previous release branch
NOTE: Drop "Clear cache when adding --new-type-inference", since it was in previous release branch
NOTE: Drop "Match note error codes to import error codes", since it was in previous release branch
NOTE: Drop "Make PEP 695 constructs give a reasonable error message", since it was in previous release branch
NOTE: Drop "Fix ParamSpec inference for callback protocols", since it was in previous release branch
NOTE: Drop "Try upgrading tox", since it was in previous release branch
NOTE: Drop "Optimize Unpack for failures", since it was in previous release branch

 * Fix crash on unpack call special-casing (Ivan Levkivskyi, PR [16381](#16381))
 * Fix file reloading in dmypy with --export-types (Ivan Levkivskyi, PR [16359](#16359))
 * Fix daemon crash caused by deleted submodule (Jukka Lehtosalo, PR [16370](#16370))
...
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants