-
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: @Theelgirl This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Just signed the CLA, waiting the "one business day" now for it to be processed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
ast27/Parser/tokenizer.c
Outdated
#endif /* PGEN */ | ||
|
||
#if PY_MINOR_VERSION >= 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.python.org/dev/whatsnew/3.10.html#id2 says we can just include Python.h instead, which we already do. So let's only include pydebug.h if PY_MINOR_VERSION < 10...
Actually, I just checked Python 3.5's Python.h (the oldest Python typed_ast supports) and it includes both pydebug and pyarena. So I think we can just remove the troublesome includes entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's possible, I didn't think of that because I don't know C. I'll test that out.
I've tested this with Python 3.10a6 in a few places, and it's not quite 100% successful.
I'll get back here if I get it compiling on macOS. |
Well, according to https://devguide.python.org/setup/#macos-and-os-x I should just run |
Have you tried the previous version of my PR, where I encased the problematic includes in an if check for python 3.10? I don't know any C or anything in depth about compilers, so that might not work, but the way I see it, its worth a shot. Edit: Could it be an incompatibility introduced by supporting the M1 chip? Have you tried this on other python versions that support M1? |
This works fine for me on macOS 10.15.7, so I propose merging and figuring out support for Apple Silicon in another place. |
Okay, will merge, and mark as closing #156. And I'll open a separate ticket for Apple Silicon. |
It seems that pydebug.h and pyarena.h were moved from /Include/ to /Include/cpython/ in the latest 3.10 alpha (a6).