-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pyjks] Fill in jks.bks and other modules, improved constructors #10815
Conversation
Additionally 1 fix to `jks.PrivateKeyEntry.__init__`
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ah thanks again, I forgot the |
We should improve the stubtest error message there — that kind of thing comes up a lot, and stubtest could be clearer about what's gone wrong in this case! |
Filed python/mypy#16210 to improve this! |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Notes below.
This comment has been minimized.
This comment has been minimized.
…s, timestamp, etc). * Added `| None` to constructor arguments that may be None * Added `@overload` constructors for encrypted and unencrypted usages * Replaced `= ...` with `= None` where appropriate * Added helpful comments to `__init__` constructors
Pushed lots of changes:
I could split these back out and open separate PR if you'd prefer. |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Additionally:
PrivateKeyEntry.__init__(encrypted=)
argumentSecretKeyEntry.__init__(sealed_obj=)
argument| None
to constructor arguments that may be None= ...
with= None
where appropriate@overload
constructors for encrypted and unencrypted usages__init__
constructors