Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdlib: Apply some simple deprecations #11044

Merged
merged 10 commits into from
Nov 23, 2023
Merged

stdlib: Apply some simple deprecations #11044

merged 10 commits into from
Nov 23, 2023

Conversation

JelleZijlstra
Copy link
Member

Split out from #11009: only deprecations that shouldn't crash pytype or stubtest.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@srittau
Copy link
Collaborator

srittau commented Nov 21, 2023

It seems xml.etree.cElementTree.Element.__bool__ (i.e. the C version) was only added in Python 3.12, while xml.etree.ElementTree.Element.__bool__ (the Python version) was always(tm) present. This confuses stubtest. Maybe split this out into a separate PR as well, as it seems to be a bit complicated?

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit c2c8d7c into python:main Nov 23, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @srittau