Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use Callable[..., Any] instead of Callable[..., object] in unittest" #8779

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Sep 21, 2022

DO NOT merge this until python/mypy#13220 is fixed.

Reverts #8373 and #8399.

@AlexWaygood AlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Sep 21, 2022
@github-actions

This comment has been minimized.

@AlexWaygood AlexWaygood marked this pull request as draft September 21, 2022 12:56
@github-actions

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented Sep 21, 2022

Thanks!

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexWaygood
Copy link
Member Author

DO NOT merge this until python/mypy#13220 is fixed.

The issue was fixed, and the fix (python/mypy@5f6961b) was included in mypy 1.7. This PR can now (finally!) be merged.

@AlexWaygood AlexWaygood marked this pull request as ready for review November 10, 2023 18:44
@AlexWaygood AlexWaygood removed the status: deferred Issue or PR deferred until some precondition is fixed label Nov 10, 2023
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit eebc287 into main Nov 10, 2023
60 checks passed
@srittau srittau deleted the revert-8399-fix-8372-unittest branch November 10, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants