Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the documentation for torch.nn.functional.pad #15984

Closed
wants to merge 3 commits into from

Conversation

bombs-kim
Copy link
Contributor

@bombs-kim bombs-kim commented Jan 12, 2019

  • Fixed a few typos and grammar errors.
  • Changed the sentences a bit.
  • Changed the format of the tuples to be consistent with padding notations in the other places. For example, ReflectionPad2d's dostring contains :math:H_{out} = H_{in} + \text{padding\_top} + \text{padding\_bottom}.

I also made sure that the generated html doesn't break.

Changed the format of the tuples to be consistent with padding notations in the other places.
@bombs-kim bombs-kim changed the title Improved documentation for torch.nn.functional.pad Improved the documentation for torch.nn.functional.pad Jan 12, 2019
Copy link
Collaborator

@ssnl ssnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants