-
Notifications
You must be signed in to change notification settings - Fork 22.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ROCm 2.4 #20253
Update ROCm 2.4 #20253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@@ -149,7 +149,7 @@ def parse_proto(x): | |||
inout_path = os.path.join(temp_dir, 'inout.npz') | |||
|
|||
# load serialized input and output | |||
loaded = np.load(inout_path, encoding='bytes') | |||
loaded = np.load(inout_path, encoding='bytes', allow_pickle=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happened here lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newest numpy changed the default value to False for security reason, in our case it's pretty safe since the serialized test files were generated by us.
@xw285cornell