Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JIT] Bind log1p and lgamma #45791

Closed
wants to merge 5 commits into from
Closed

Conversation

eellison
Copy link
Contributor

@eellison eellison commented Oct 2, 2020

Stack from ghstack:

Most of the lowering for log1p and lgamma already existed, add JIT integration.

Differential Revision: D24169536

[ghstack-poisoned]
@eellison eellison requested a review from apaszke as a code owner October 2, 2020 23:49
eellison pushed a commit that referenced this pull request Oct 2, 2020
ghstack-source-id: 73653eaeeb6302c305423673db9ae48c2d9f1770
Pull Request resolved: #45791
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 2, 2020
eellison pushed a commit that referenced this pull request Oct 5, 2020
ghstack-source-id: fd6878fb1d6d79f899b7dea349d05d9b39febc23
Pull Request resolved: #45791
@eellison eellison changed the title Bind log1p and lgamma [JIT] Bind log1p and lgamma Oct 5, 2020
Most of the lowering for log1p and lgamma already existed, add JIT integration.


[ghstack-poisoned]
eellison pushed a commit that referenced this pull request Oct 5, 2020
ghstack-source-id: 84a195dd95d1216c8e12d84deae00d35040a9e63
Pull Request resolved: #45791
@Krovatkin Krovatkin self-requested a review October 6, 2020 16:52
Copy link
Contributor

@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Most of the lowering for log1p and lgamma already existed, add JIT integration.


[ghstack-poisoned]
eellison pushed a commit that referenced this pull request Oct 7, 2020
ghstack-source-id: c6df4fd9d9ada3e44429d71e49abaadd1a0a8b2d
Pull Request resolved: #45791
Most of the lowering for log1p and lgamma already existed, add JIT integration.

Differential Revision: [D24169536](https://our.internmc.facebook.com/intern/diff/D24169536)

[ghstack-poisoned]
eellison pushed a commit that referenced this pull request Oct 7, 2020
ghstack-source-id: 17318ea56086e2ab4521f29a356afce3034f79d3
Pull Request resolved: #45791
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (gh/eellison/115/base@cf02161). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##             gh/eellison/115/base   #45791   +/-   ##
=======================================================
  Coverage                        ?   68.23%           
=======================================================
  Files                           ?      410           
  Lines                           ?    53266           
  Branches                        ?        0           
=======================================================
  Hits                            ?    36347           
  Misses                          ?    16919           
  Partials                        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf02161...9a3c6fb. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@eellison merged this pull request in 1197a38.

@facebook-github-bot facebook-github-bot deleted the gh/eellison/115/head branch October 12, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants