[NCCL] warn when barrier guesses device to use #54991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actual proposed fix is in #53934, in the meantime, would be useful to include this LOG when barrier does not know what devices to use, and suggest the workaround of passing in device_ids into barrier(). Differential Revision: [D27444917](https://our.internmc.facebook.com/intern/diff/D27444917/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
wayi1 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 532b673 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Mar 30, 2021
Actual proposed fix is in #53934, in the meantime, would be useful to include this LOG when barrier does not know what devices to use, and suggest the workaround of passing in device_ids into barrier(). Differential Revision: [D27444917](https://our.internmc.facebook.com/intern/diff/D27444917/) ghstack-source-id: 125304647 Pull Request resolved: #54991
rohan-varma
changed the title
wayi1
reviewed
Apr 12, 2021
| " using best-guess GPU ", | ||
| deviceIdx, | ||
| " to perform barrier as devices used by this process are currently unknown. ", | ||
| "Specify device_ids in barrier() to force use of a particular device." |
There was a problem hiding this comment.
Better to say "To avoid any potential hang due to a wrong guess, please specify ...". This can improve the debuggability by mentioning the potential outcome if the warning here is ignored.
wayi1
approved these changes
Apr 12, 2021
wayi1
reviewed
Apr 12, 2021
torch/lib/c10d/ProcessGroupNCCL.cpp
Outdated
| " to perform barrier as devices used by this process are currently unknown. ", | ||
| "Specify device_ids in barrier() to force use of a particular device." | ||
| ); | ||
| LOG(WARNING) << bestGuessWarning; |
There was a problem hiding this comment.
Nit: Since bestGuessWarning wont' be used anywhere else, can just log everything directly after LOG(WARNING) and no need to construct a separate string.
Actual proposed fix is in #53934, in the meantime, would be useful to include this LOG when barrier does not know what devices to use, and suggest the workaround of passing in device_ids into barrier(). Differential Revision: [D27444917](https://our.internmc.facebook.com/intern/diff/D27444917/) [ghstack-poisoned]
Actual proposed fix is in #53934, in the meantime, would be useful to include this LOG when barrier does not know what devices to use, and suggest the workaround of passing in device_ids into barrier(). Differential Revision: [D27444917](https://our.internmc.facebook.com/intern/diff/D27444917/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 12, 2021
Pull Request resolved: #54991 Actual proposed fix is in #53934, in the meantime, would be useful to include this LOG when barrier does not know what devices to use, and suggest the workaround of passing in device_ids into barrier(). ghstack-source-id: 126351889 Differential Revision: [D27444917](https://our.internmc.facebook.com/intern/diff/D27444917/)
|
This pull request has been merged in 657b66e. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#54991 Actual proposed fix is in pytorch#53934, in the meantime, would be useful to include this LOG when barrier does not know what devices to use, and suggest the workaround of passing in device_ids into barrier(). ghstack-source-id: 126351889 Test Plan: CI Reviewed By: SciPioneer Differential Revision: D27444917 fbshipit-source-id: 0f269c5a7732e5be6e51adfca7ef70d04ffd71d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Actual proposed fix is in
#53934, in the meantime, would be useful
to include this LOG when barrier does not know what devices to use, and suggest
the workaround of passing in device_ids into barrier().
Differential Revision: D27444917