Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyTorchStreamWriter exception handling #88128

Closed
wants to merge 1 commit into from

Commits on Oct 31, 2022

  1. Fix PyTorchStreamWriter exception handling

    Avoid double exception in destructor if attempting to serialize to
    python object that does not have `write` method
    
    Use `Finalizer` class in `PyTorchStreamWriter::writeEndOfFile()` to a
    always set `finailized_` property even if excretion occurs. (as there
    isn't much one can do at this point)
    
    Add expicit check for the attribue to `_open_zipfile_writer_buffer` and
    add unitests
    
    Modernize code a bit by using Python-3 `super()` method
    
    Fixes #87997
    malfet committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    7b8a002 View commit details
    Browse the repository at this point in the history