-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Add PIL 4.1.1 to CI checks #3638
Conversation
@fmassa this is still WIP but the CI failures of
I think we should avoid this and bump the minimal required version to IMHO it's not ideal to have more than one minimal version requirements for the dependencies. It might seem like we're doing the users a favour by treating some features as "opt-in", but in reality this is likely to complicate their lives. If a user wants to use e.g. CC @oke-aditya |
I think 5.3.0 seems to have made a lot of changes in plotting APIs. Looking at docs I see that many functionalities differed from v5.3.0 Also by default torchvision installs the latest pillow (tested by conda and pip installing torchvision locally). (it installed 8.2 last week and 8.3 this week) I agree with @NicolasHug that this bump would solve the issue. It will help to clean up the code of |
Ok with me to bump the minimum version to be 5.3.0 |
This PR lets the linux/mac 3.6 unittest runs use pillow=4.1.1 instead of the latest pil version.
Addresses #3631 (comment)