id: fix String() and add tests for edge cases while unmarshaling byte…

…s into ids

.codecov.yml

@@ -4,7 +4,9 @@ codecov:
   max_report_age: off
 
 ignore:
-  - "./cmd"
+  - "./cmd/basic"
+  - "./cmd/benchmark_rpc"
+  - "./cmd/benchmark_send"
 
 comment: false
 

id.go

@@ -40,11 +40,11 @@ func (e ID) Size() int {
 // String returns a JSON representation of this ID.
 func (e ID) String() string {
 	var builder strings.Builder
-	builder.WriteString(`{"public_key": `)
+	builder.WriteString(`{"public_key": "`)
 	builder.WriteString(hex.EncodeToString(e.ID[:]))
-	builder.WriteString(`, "address": `)
+	builder.WriteString(`", "address": "`)
 	builder.WriteString(e.Address)
-	builder.WriteString("}")
+	builder.WriteString(`"}`)
 	return builder.String()
 }
 

id_test.go

@@ -0,0 +1,55 @@
+package noise_test
+
+import (
+	"fmt"
+	"github.com/perlin-network/noise"
+	"github.com/stretchr/testify/assert"
+	"io"
+	"net"
+	"strconv"
+	"testing"
+	"testing/quick"
+)
+
+func TestID_String(t *testing.T) {
+	t.Parallel()
+
+	f := func(publicKey noise.PublicKey, host net.IP, port uint16) bool {
+		h := host.String() // Make-shift 'normalizeIP(net.IP)'.
+		if h == "<nil>" {
+			h = ""
+		}
+
+		id := noise.NewID(publicKey, host, port)
+
+		if !assert.Equal(t,
+			fmt.Sprintf(
+				`{"public_key": "%s", "address": "%s"}`,
+				publicKey, net.JoinHostPort(h, strconv.FormatUint(uint64(port), 10)),
+			),
+			id.String(),
+		) {
+			return false
+		}
+
+		return true
+	}
+
+	assert.NoError(t, quick.Check(f, nil))
+}
+
+func TestUnmarshalID(t *testing.T) {
+	t.Parallel()
+
+	_, err := noise.UnmarshalID(nil)
+	assert.EqualError(t, err, io.ErrUnexpectedEOF.Error())
+
+	_, err = noise.UnmarshalID(append(noise.ZeroPublicKey[:], 1))
+	assert.EqualError(t, err, io.ErrUnexpectedEOF.Error())
+
+	_, err = noise.UnmarshalID(append(noise.ZeroPublicKey[:], append(net.IPv6loopback, 1)...))
+	assert.EqualError(t, err, io.ErrUnexpectedEOF.Error())
+
+	_, err = noise.UnmarshalID(append(noise.ZeroPublicKey[:], append(net.IPv6loopback, 1, 2)...))
+	assert.NoError(t, err)
+}