before release

* API changed a bit before release, readmefile, version bump * updated tests * updated tests * small code cleanup
qatoolkit · Dec 6, 2020 · 6ac166e · 6ac166e
1 parent b98c34c
commit 6ac166e
Show file tree

Hide file tree

Showing 6 changed files with 47 additions and 3 deletions.
diff --git a/src/QAToolKit.Auth.Test/Keycloak/KeycloakAuthenticatorTests.cs b/src/QAToolKit.Auth.Test/Keycloak/KeycloakAuthenticatorTests.cs
@@ -0,0 +1,41 @@
+using NSubstitute;
+using QAToolKit.Core.Interfaces;
+using System;
+using System.Threading.Tasks;
+using Xunit;
+
+namespace QAToolKit.Auth.Test.Keycloak
+{
+    public class KeycloakAuthenticatorTests
+    {
+        [Fact]
+        public async Task CreateAuthenticatonServiceTest_Success()
+        {
+            var authenticator = Substitute.For<IAuthenticationService>();
+            await authenticator.GetAccessToken();
+            Assert.Single(authenticator.ReceivedCalls());
+        }
+
+        [Fact]
+        public async Task CreateAuthenticatonServiceWithReturnsTest_Success()
+        {
+            var authenticator = Substitute.For<IAuthenticationService>();
+            authenticator.GetAccessToken().Returns(args => "12345");
+
+            Assert.Equal("12345", await authenticator.GetAccessToken());
+            Assert.Single(authenticator.ReceivedCalls());
+        }
+
+        [Fact]
+        public void CreateKeycloakOptionsTest_Success()
+        {
+            var options = new KeycloakOptions();
+            options.AddClientCredentialFlowParameters(new Uri("https://api.com/token"), "12345", "12345");
+            options.AddUserNameForImpersonation("myemail@email.com");
+
+            var keycloakOptions = Substitute.For<Action<KeycloakOptions>>();
+            keycloakOptions.Invoke(options);
+            Assert.Single(keycloakOptions.ReceivedCalls());
+        }
+    }
+}
diff --git a/src/QAToolKit.Auth.Test/QAToolKit.Auth.Test.csproj b/src/QAToolKit.Auth.Test/QAToolKit.Auth.Test.csproj
@@ -13,7 +13,8 @@
     </PackageReference>
     <PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="5.0.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
+    <PackageReference Include="NSubstitute" Version="4.2.2" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
       <PrivateAssets>all</PrivateAssets>

diff --git a/src/QAToolKit.Auth/Keycloak/Exceptions/KeycloakAccessDeniedException.cs b/src/QAToolKit.Auth/Keycloak/Exceptions/KeycloakAccessDeniedException.cs
@@ -5,6 +5,7 @@ namespace QAToolKit.Auth.Exceptions
     /// <summary>
     /// Keycloak access denied exception
     /// </summary>
+    [Serializable]
     public class KeycloakAccessDeniedException : Exception
     {
         /// <summary>

diff --git a/src/QAToolKit.Auth/Keycloak/Exceptions/KeycloakException.cs b/src/QAToolKit.Auth/Keycloak/Exceptions/KeycloakException.cs
@@ -5,6 +5,7 @@ namespace QAToolKit.Auth.Exceptions
     /// <summary>
     /// Keycloak exception
     /// </summary>
+    [Serializable]
     public class KeycloakException : Exception
     {
         /// <summary>

diff --git a/src/QAToolKit.Auth/Keycloak/Exceptions/KeycloakUnauthorizedClientException.cs b/src/QAToolKit.Auth/Keycloak/Exceptions/KeycloakUnauthorizedClientException.cs
@@ -5,6 +5,7 @@ namespace QAToolKit.Auth.Exceptions
     /// <summary>
     /// Keycloak unauthorized client exception
     /// </summary>
+    [Serializable]
     public class KeycloakUnauthorizedClientException : Exception
     {
         /// <summary>

diff --git a/src/QAToolKit.Auth/Keycloak/KeycloakTokenService.cs b/src/QAToolKit.Auth/Keycloak/KeycloakTokenService.cs
@@ -9,7 +9,6 @@ namespace QAToolKit.Auth
 {
     internal class KeycloakTokenService : IDisposable
     {
-        private const int TokenValidityOffsetSeconds = 15;
         private readonly HttpClient _client;
         private readonly Uri _tokenEndpoint;
         private readonly string _clientId;
@@ -121,7 +120,7 @@ private HttpRequestMessage CreateBasicTokenEndpointRequest()
             return request;
         }
 
-        private void SetRequestAcceptHeader(HttpRequestMessage req)
+        private static void SetRequestAcceptHeader(HttpRequestMessage req)
         {
             req.Headers.Add("Accept", "application/json");
         }