Fixed the problem of generating wrong formula caused by RemoveCol #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1880 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 32 32
Lines 24069 24071 +2
=======================================
+ Hits 23880 23882 +2
Misses 101 101
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…none formula data validation rules - Update dependencies module to fix vulnerabilities - Update unit tests
xuri
added
the
size/M
xuri
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Thanks for your pull request. I have made some changes based on your code. Different from Microsoft Excel, the double quote symbol in non-formula data validation rules will be escaped in the Kingsoft WPS Office. I have added a guard for this situation to skip and adjust the non-formula data validation rule to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
#1879
Related Issue
#1879
Motivation and Context
#1879
How Has This Been Tested
Types of changes
Checklist