Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support parse string as char[n] #183

Merged
merged 2 commits into from
Jun 30, 2023
Merged

support parse string as char[n] #183

merged 2 commits into from
Jun 30, 2023

Conversation

bbbgan
Copy link
Collaborator

@bbbgan bbbgan commented Jun 29, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13 🎉

Comparison is base (8f74581) 46.37% compared to head (3d02c7a) 46.51%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   46.37%   46.51%   +0.13%     
==========================================
  Files          42       42              
  Lines        5947     5962      +15     
==========================================
+ Hits         2758     2773      +15     
  Misses       3189     3189              
Impacted Files Coverage Δ
iguana/json_util.hpp 22.72% <ø> (ø)
iguana/json_reader.hpp 75.00% <100.00%> (+1.47%) ⬆️
iguana/json_writer.hpp 100.00% <100.00%> (ø)
test/unit_test.cpp 99.61% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbbgan bbbgan merged commit 0e6fb68 into qicosmos:master Jun 30, 2023
10 checks passed
171930433 pushed a commit to 171930433/iguana that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants