Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize recursive type definition #36

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Optimize recursive type definition #36

merged 1 commit into from
Apr 27, 2021

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Mar 6, 2021 •
edited
Loading

Benefited from Recursive Type Alias introduced in Typescript 3.7, now we can simplify the definition for ValueOf related types.

lzfee0227
lzfee0227 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Collaborator

@lzfee0227 lzfee0227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nighca nighca merged commit 65bd52a into qiniu:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzfee0227 lzfee0227 lzfee0227 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nighca @lzfee0227