update logic of resolve async results #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
reviewed
Mar 11, 2022
src/utils.ts
Outdated
| @@ -15,18 +15,19 @@ export function asyncResultsAnd(asyncResults: Array<Promise<ValidationResult>>): | |||
| return null | |||
| } | |||
| return new Promise(resolve => { | |||
| // 任一不通过，则不通过 | |||
| let count = 0 | |||
There was a problem hiding this comment.
Suggested change
| let count = 0 | |
| let validResultCount = 0 |
| asyncResults.forEach(asyncResult => asyncResult.then(result => { | ||
| // return error if any result is invalid | ||
| if (!isValid(result)) { | ||
| resolve(result) |
There was a problem hiding this comment.
这里最好 return 下，invalid 的话就不应该执行后边的逻辑了（虽然在目前的代码下不会导致问题）
nighca
reviewed
Mar 11, 2022
src/utils.ts
Outdated
| if (!isValid(result)) { | ||
| resolve(result) | ||
| validResultCount = -1 |
There was a problem hiding this comment.
🤣 我不是指第 i 个 result invalid 的话，就不去处理后边的 i+1, i+2, ... 的 result，那个处理了也没事的，最多就是多执行两行代码，不会影响逻辑的正确性
我是指，在对第 i 个 result 进行处理的时候，如果它 invalid，就不应该执行后边的：
validResultCount++
// pass if all results are valid
if (validResultCount === asyncResults.length) {
...
}这会引入一些逻辑上的潜在风险，比如 validResultCount 值不能正确地匹配它的定位，对于它的消费有可能会导致 bug
现在设置 validResultCount 为 -1 以跳过 i+1, i+2, ... 的做法会让逻辑本身变复杂，我个人倾向可以不要这个逻辑？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.