fix: limit the number of annotations

qiniu · Aug 29, 2024 · 85c39d8 · 85c39d8
1 parent 3269168
commit 85c39d8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/internal/linters/github.go b/internal/linters/github.go
@@ -137,6 +137,11 @@ func CreateGithubChecks(ctx context.Context, a Agent, lintErrs map[string][]Lint
 	)
 
 	annotations := toGithubCheckRunAnnotations(lintErrs)
+	// limit the number of annotations to 50
+	// see: https://github.com/qiniu/reviewbot/issues/258
+	if len(annotations) > 50 {
+		annotations = annotations[:50]
+	}
 
 	check := github.CreateCheckRunOptions{
 		Name:      linterName,

diff --git a/internal/runner/runner.go b/internal/runner/runner.go
@@ -112,7 +112,7 @@ func (*LocalRunner) Run(ctx context.Context, cfg *config.Linter) (io.ReadCloser,
 	return io.NopCloser(bytes.NewReader(output)), execErr
 }
 
-// for easy mock
+// for easy mock.
 type DockerClientInterface interface {
 	ImageInspectWithRaw(ctx context.Context, imageID string) (types.ImageInspect, []byte, error)
 	ImagePull(ctx context.Context, refStr string, options image.PullOptions) (io.ReadCloser, error)