fix(luacheck) filter out unnecessary lines

internal/linters/lua/luacheck/luacheck.go

@@ -19,24 +19,43 @@ func luacheckHandler(log *xlog.Logger, a linters.Agent) error {
 	if linters.IsEmpty(a.LinterConfig.Args...) {
 		// identify global variables for Redis and Nginx modules.
 		// disable the maximum line length check, which is no need.
-		a.LinterConfig.Args = append([]string{}, ".", "--globals='ngx KEYS ARGV table redis cjson'", "--no-max-line-length")
+		// luacheck execute the command "--globals='ngx KEYS ARGV table redis cjson'", which does not take effect. So the parameter should be changed to an array-based approach.
+		cmdArgs := []string{
+			".",
+			"--globals=ngx",
+			"--globals=KEYS",
+			"--globals=ARGV",
+			"--globals=table",
+			"--globals=redis",
+			"--globals=cjson",
+			"--no-max-line-length",
+			"--no-color",
+		}
+		a.LinterConfig.Args = append([]string{}, cmdArgs...)
 	}
 
 	return linters.GeneralHandler(log, a, func(_ *xlog.Logger, output []byte) (map[string][]linters.LinterOutput, error) {
-		return linters.Parse(log, output, luacheckParser)
+		return linters.Parse(log, output, luacheckLineParser)
 	})
 }
 
-func luacheckParser(line string) (*linters.LinterOutput, error) {
-	lineResult, err := linters.GeneralLineParser(line)
-	if err != nil {
-		return nil, err
+func luacheckLineParser(line string) (*linters.LinterOutput, error) {
+	filteredLine := luacheckLineProcess(line)
+	if filteredLine != "" {
+		return linters.GeneralLineParser(filteredLine)
+	}
+	return nil, nil
+}
 
+func luacheckLineProcess(line string) string {
+	// Luacheck will output lines starting with 'Total ' or 'Checking ', which are no meaningful for the reviewbot scenario, so we discard them
+	// Such as:
+	// 1. Total: 0 warnings / 0 errors in 0 files
+	// 2. Checking cmd/jarviswsserver/etc/get_node_wsserver.lua 11 warnings
+	if strings.HasPrefix(line, "Total: ") || strings.HasPrefix(line, "Checking ") {
+		return ""
 	}
-	return &linters.LinterOutput{
-		File:    strings.TrimLeft(lineResult.File, " "),
-		Line:    lineResult.Line,
-		Column:  lineResult.Column,
-		Message: strings.ReplaceAll(strings.ReplaceAll(lineResult.Message, "\x1b[0m\x1b[1m", ""), "\x1b[0m", ""),
-	}, nil
+	// Luacheck will output lines starting with unrecognized characters, so we discard them
+	//re := regexp.MustCompile(`\x1b\[0m\x1b\[1m|\x1b\[0m`)
+	return strings.TrimLeft(line, " ")
 }

internal/linters/lua/luacheck/luacheck_test.go

@@ -55,7 +55,7 @@ func TestFormatLuaCheckLine(t *testing.T) {
 	}
 
 	for _, c := range tc {
-		output, err := luacheckParser(c.input)
+		output, err := luacheckLineParser(c.input)
 		if output == nil {
 			if c.expected != nil {
 				t.Errorf("expected: %v, got: %v", c.expected, output)