Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): support linter's config path #151

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

CarlJi
Copy link
Contributor

@CarlJi CarlJi commented Jun 7, 2024

No description provided.

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit ab5fba7
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/6662e41dc4327100088f2f47

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 37.14%. Comparing base (e619b44) to head (72fe3c6).

Current head 72fe3c6 differs from pull request most recent head ab5fba7

Please upload reports for the commit ab5fba7 to get more accurate results.

Files Patch % Lines
config/config.go 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   36.79%   37.14%   +0.35%     
==========================================
  Files          10       10              
  Lines         810      821      +11     
==========================================
+ Hits          298      305       +7     
- Misses        486      488       +2     
- Partials       26       28       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlJi CarlJi merged commit 74f8d3f into qiniu:master Jun 7, 2024
8 checks passed
@CarlJi CarlJi deleted the feat/golangci-lint branch June 7, 2024 10:46
@never112
Copy link
Contributor

never112 commented Jun 7, 2024

需要这个配置的,有些规则对项目不一定适合,有些文件不需要进行检查,需要 exclude 也是在这个文件配置吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants