Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version command #162

Merged
merged 6 commits into from
Jun 14, 2024
Merged

feat: add version command #162

merged 6 commits into from
Jun 14, 2024

Conversation

jimyag
Copy link
Contributor

@jimyag jimyag commented Jun 12, 2024

No description provided.

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 06b66bb
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/666b027c36fadd0009f51840

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.74%. Comparing base (405f67d) to head (06b66bb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   37.74%   37.74%           
=======================================
  Files          10       10           
  Lines         853      853           
=======================================
  Hits          322      322           
  Misses        502      502           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

main.go Outdated Show resolved Hide resolved
@CarlJi
Copy link
Contributor

CarlJi commented Jun 13, 2024

reviewbot 当前主要是以服务端形式部署,但从推广的角度,以后应该会引入CLI模式。 相关issue: #59

到时,flag这块应该会着重设计。

@jimyag
Copy link
Contributor Author

jimyag commented Jun 13, 2024

reviewbot 当前主要是以服务端形式部署,但从推广的角度,以后应该会引入CLI模式。 相关issue: #59

到时,flag这块应该会着重设计。

之后可以考虑使用 https://github.com/spf13/cobra 重构。
可以是
reviewbot server 启动服务
revieebot deploy 部署到 xxx
可以参考 hugo 的命令

hugo is the main command, used to build your Hugo site.

Hugo is a Fast and Flexible Static Site Generator
built with love by spf13 and friends in Go.

Complete documentation is available at https://gohugo.io/.

Usage:
  hugo [flags]
  hugo [command]

Available Commands:
  completion  Generate the autocompletion script for the specified shell
  config      Print the site configuration
  convert     Convert your content to different formats
  deploy      Deploy your site to a Cloud provider.
  env         Print Hugo version and environment info
  gen         A collection of several useful generators.
  help        Help about any command
  import      Import your site from others.
  list        Listing out various types of content
  mod         Various Hugo Modules helpers.
  new         Create new content for your site
  server      A high performance webserver
  version     Print Hugo version and environment info

@jimyag jimyag requested a review from CarlJi June 13, 2024 11:51
Copy link

qiniu-x bot commented Jun 13, 2024

[Git-flow] Hi @jimyag, There are some suggestions for your information:


Rebase suggestions

  • Following commits seems generated via git merge

    Merge branch 'master' into feat-version-cmd

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

@CarlJi CarlJi merged commit 0a243c3 into qiniu:master Jun 14, 2024
9 checks passed
@jimyag jimyag deleted the feat-version-cmd branch June 14, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants