fix(gofmt): fix the issue where the gofmt stderr is not handled #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reviewbot-x canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 37.61% 37.18% -0.44%
==========================================
Files 10 10
Lines 856 866 +10
==========================================
Hits 322 322
- Misses 505 515 +10
Partials 29 29 ☔ View full report in Codecov by Sentry. |
|
fix #169 |
CarlJi
reviewed
Jun 14, 2024
| if c.Stderr != nil { | ||
| return nil, nil, errors.New("exec: Stderr already set") | ||
| } | ||
| var stdoutBuffer bytes.Buffer |
There was a problem hiding this comment.
1、gofmt 检查出的lint问题是存储在stdout中，
2、而像expected 'package' 错误是会在stderr中体现，
3、像找不到文件路径执行gofmt 报错则会出现在err := c.Run() 中。
若直接使用combineoutput方法则会将stdout和stderr内容同时输出到一个Buffer中，不易区分
因此这里其实是改写了combineoutput，让其分别返回stdout和stderr，分别处理
CarlJi
reviewed
Jun 17, 2024
| c := exec.Command(command, args...) | ||
| c.Dir = dir | ||
| log.Printf("final command: %v \n", c) | ||
| return c.Output() | ||
| if c.Stdout != nil { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.