Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make command as slice to extend its usage #205

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

CarlJi
Copy link
Contributor

@CarlJi CarlJi commented Jun 26, 2024

No description provided.

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit cc8ebe9
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/667be12722b1c1000832684a

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 38.57%. Comparing base (3276e81) to head (cc8ebe9).

Files Patch % Lines
internal/linters/linters.go 14.28% 18 Missing ⚠️
config/config.go 66.66% 0 Missing and 1 partial ⚠️
internal/linters/github.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   38.42%   38.57%   +0.14%     
==========================================
  Files          11       11              
  Lines         903      897       -6     
==========================================
- Hits          347      346       -1     
+ Misses        527      522       -5     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlJi CarlJi force-pushed the fix/alert branch 2 times, most recently from 022a8b8 to 7473fbb Compare June 26, 2024 09:31
@CarlJi CarlJi closed this Jun 26, 2024
@CarlJi CarlJi reopened this Jun 26, 2024
@CarlJi CarlJi merged commit 971f71b into qiniu:master Jun 26, 2024
9 of 10 checks passed
@CarlJi CarlJi deleted the fix/alert branch June 26, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant