Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: output parser v2 #224

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

CarlJi
Copy link
Contributor

@CarlJi CarlJi commented Jul 6, 2024

fix #198

Copy link

netlify bot commented Jul 6, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 797ce38
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/6698ea0e8ea1400008316289

@CarlJi CarlJi changed the title [WIP]fix: golangci-lint output parser fix: golangci-lint output parser Jul 18, 2024
@CarlJi CarlJi force-pushed the feat/golangci-lint-mod branch 2 times, most recently from 932e776 to 3029bef Compare July 18, 2024 09:21
@CarlJi CarlJi changed the title fix: golangci-lint output parser refactor: output parser v2 Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 37.95%. Comparing base (af48f24) to head (797ce38).

Files Patch % Lines
internal/linters/linters.go 88.88% 4 Missing and 2 partials ⚠️
internal/linters/go/golangci_lint/golangci_lint.go 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   35.64%   37.95%   +2.30%     
==========================================
  Files          19       19              
  Lines        1327     1386      +59     
==========================================
+ Hits          473      526      +53     
- Misses        814      818       +4     
- Partials       40       42       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlJi CarlJi force-pushed the feat/golangci-lint-mod branch 5 times, most recently from d5da433 to e2da2fc Compare July 18, 2024 10:07
@CarlJi CarlJi closed this Jul 18, 2024
@CarlJi CarlJi reopened this Jul 18, 2024
@CarlJi CarlJi merged commit 515b073 into qiniu:master Jul 18, 2024
8 checks passed
@CarlJi CarlJi deleted the feat/golangci-lint-mod branch July 18, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golangci-lint: issue debug
1 participant