feat: log storage and visualization #297

wwcchh0123 · 2024-08-30T04:01:29Z

No description provided.

netlify · 2024-08-30T04:01:43Z

✅ Deploy Preview for reviewbot-x canceled.

Name	Link
🔨 Latest commit	`6ba6c64`
🔍 Latest deploy log	https://app.netlify.com/sites/reviewbot-x/deploys/66d6b9820f95e60008a30455

codecov · 2024-08-30T04:02:59Z

Codecov Report

Attention: Patch coverage is 0% with 73 lines in your changes missing coverage. Please review.

Project coverage is 36.17%. Comparing base (c0ebeab) to head (39abe89).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/storage/local.go	0.00%	29 Missing ⚠️
server.go	0.00%	14 Missing ⚠️
main.go	0.00%	10 Missing ⚠️
internal/linters/linters.go	0.00%	6 Missing and 1 partial ⚠️
internal/storage/aws.go	0.00%	6 Missing ⚠️
internal/storage/git.go	0.00%	6 Missing ⚠️
internal/linters/github.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   37.60%   36.17%   -1.44%     
==========================================
  Files          23       26       +3     
  Lines        1819     1891      +72     
==========================================
  Hits          684      684              
- Misses       1053     1124      +71     
- Partials       82       83       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/storage/aws.go

internal/storage/local.go

CarlJi · 2024-09-03T08:27:37Z

internal/storage/file.go

+		return nil, fmt.Errorf("file does not exist: %s", filePath)
+	}
+
+	g.mu.Lock()


应该不用加锁？

CarlJi · 2024-09-03T08:28:06Z

internal/storage/file.go

+	defer file.Close()
+
+	select {
+	case <-ctx.Done():


不支持cancel应该还好吧？

CarlJi · 2024-09-03T08:28:51Z

main.go

@@ -149,6 +151,7 @@ func main() {

 	mux := http.NewServeMux()
 	mux.Handle("/", s)
+	mux.Handle("/view/", HandleView(storage.NewLocalStorage()))


storage 应该是Server的一部分

CarlJi · 2024-09-03T08:36:23Z

server.go

+		logStorageConfig := s.config.LogStorageConfig
+		if len(logStorageConfig.CustomRemoteConfigs) == 0 {
+			agent.LogStorage = storage.NewLocalStorage()
+		} else {
+			for remoteName, storageConfig := range logStorageConfig.CustomRemoteConfigs {
+				switch remoteName {
+				case "github":
+					agent.LogStorage = storage.NewGitubStorage(storageConfig.(config.GithubConfig))
+				default:
+					log.Warnf("%s was wrong storageType", remoteName)
+				}
+			}
+		}
+
+		agent.LinterUuid = uuid.New().String()
+		agent.LinterLogStoragePath = fmt.Sprintf("linter-logs/%s/%d/%s/log-build.txt", *agent.PullRequestEvent.Repo.Name, *agent.PullRequestEvent.Number, agent.LinterUuid)
+		agent.LinterLogViewUrl = "http://" + s.config.ServerAddr + "/view/" + agent.LinterLogStoragePath
+
+		// s.config.ServerAddr = "localhost:8888"
+		// log.Debugf("---------LinterLogViewUrl---------   : %s", agent.LinterLogViewUrl)
+


跟主逻辑的交互太多了，感觉解耦的不够

wwcchh0123 force-pushed the feat/logstorage_v2 branch 3 times, most recently from 8855b50 to 39abe89 Compare August 30, 2024 09:35