Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gomodcheck): use modfile #307

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

CarlJi
Copy link
Contributor

@CarlJi CarlJi commented Sep 2, 2024

No description provided.

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 5ca143a
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/66d5a6ea4177b5000856fe08

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 36.69%. Comparing base (c7ca1d7) to head (5ca143a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/linters/go/gomodcheck/gomodcheck.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   36.54%   36.69%   +0.15%     
==========================================
  Files          24       24              
  Lines        1880     1872       -8     
==========================================
  Hits          687      687              
+ Misses       1111     1103       -8     
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlJi CarlJi force-pushed the fix/custom_runner_fix branch 3 times, most recently from 161e1c3 to a85e340 Compare September 2, 2024 11:35
@CarlJi CarlJi changed the title build: make go version consistent with golangci-lint fix(gomodcheck): use modfile Sep 2, 2024
@CarlJi CarlJi merged commit 3844509 into qiniu:master Sep 3, 2024
8 of 9 checks passed
@CarlJi CarlJi deleted the fix/custom_runner_fix branch September 3, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant