fix: re-run #320
Merged
fix: re-run #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reviewbot-x canceled.
|
CarlJi
reviewed
Sep 4, 2024
server.go
Outdated
| installationID := event.GetInstallation().GetID() | ||
| plist, err := linters.FilterPullRequestsWithCommit(ctx, s.GithubClient(installationID), org, repo, headSha) | ||
| if err != nil { | ||
| log.Debugf("Filter pullreqeust fail %v\n", err) |
CarlJi
reviewed
Sep 4, 2024
never112
force-pushed
the
zhou0904
branch
2 times, most recently
from
882f1e9
to
4472a87
Compare
CarlJi
reviewed
Sep 5, 2024
internal/linters/github.go
Outdated
| StartedAt: &startTime, | ||
| Name: linterName, | ||
| HeadSHA: headSha, | ||
| DetailsURL: &url, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
==========================================
- Coverage 37.22% 36.52% -0.70%
==========================================
Files 27 27
Lines 1996 2034 +38
==========================================
Hits 743 743
- Misses 1158 1196 +38
Partials 95 95 ☔ View full report in Codecov by Sentry. |
never112
force-pushed
the
zhou0904
branch
4 times, most recently
from
7b3af55
to
c87d3b3
Compare
CarlJi
reviewed
Sep 6, 2024
internal/linters/github.go
Outdated
| repullRequests = append(repullRequests, pullRequest) | ||
| } | ||
| } | ||
| if err != nil { |
CarlJi
reviewed
Sep 6, 2024
internal/linters/github.go
Outdated
| func FilterPullRequestsWithCommit(ctx context.Context, gc *github.Client, owner string, repo string, headSha string) ([]*github.PullRequest, error) { | ||
| plopt := github.PullRequestListOptions{} | ||
| var repullRequests []*github.PullRequest | ||
| pullRequests, _, err := gc.PullRequests.List(ctx, owner, repo, &plopt) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.