Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker runner and s3 log fix #364

Merged
merged 3 commits into from
Sep 11, 2024
Merged

docker runner and s3 log fix #364

merged 3 commits into from
Sep 11, 2024

Conversation

CarlJi
Copy link
Contributor

@CarlJi CarlJi commented Sep 11, 2024

No description provided.

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 65f0621
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/66e146e2ca74f100082e17c4

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 36.48%. Comparing base (48caae4) to head (65f0621).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/storage/s3.go 0.00% 6 Missing ⚠️
internal/runner/docker.go 55.55% 2 Missing and 2 partials ⚠️
main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   36.46%   36.48%   +0.01%     
==========================================
  Files          27       27              
  Lines        2235     2245      +10     
==========================================
+ Hits          815      819       +4     
- Misses       1302     1307       +5     
- Partials      118      119       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlJi CarlJi merged commit 0589958 into qiniu:master Sep 11, 2024
8 checks passed
@CarlJi CarlJi deleted the fix/linter_config branch September 11, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant