Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use strict unmarshall for config #379

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

CarlJi
Copy link
Contributor

@CarlJi CarlJi commented Sep 19, 2024

No description provided.

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for reviewbot-x ready!

Name Link
🔨 Latest commit c57924d
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/66ec02b79a3c1f0008666843
😎 Deploy Preview https://deploy-preview-379--reviewbot-x.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.04%. Comparing base (0b52b43) to head (c57924d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
config/config.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   36.01%   36.04%   +0.02%     
==========================================
  Files          27       27              
  Lines        2324     2325       +1     
==========================================
+ Hits          837      838       +1     
  Misses       1364     1364              
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlJi CarlJi merged commit e433225 into qiniu:master Sep 20, 2024
7 of 8 checks passed
@CarlJi CarlJi deleted the fix/linter_config branch September 20, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant