Fix test suite to account for beta numpy versions #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the numpy version check in the test suite to account
for the possibility that `numpy.__version__` may contain letters.
Prior to this change, running tests on numpy 1.26.0b1 would result
in the following error:
```
test/python/algorithms/optimizers/test_optimizers_scikitquant.py:72: in TestOptimizers
tuple(map(int, numpy.__version__.split("."))) >= (1, 24, 0),
E ValueError: invalid literal for int() with base 10: '0b1'
```
Since the third component is matched against zero, the simplest solution
is to check only the first two components, since we can expect that
the first two split elements will be integers.
This is synced from the equivalent qiskit change:
Qiskit/qiskit#10723
3 tasks
woodsp-ibm
approved these changes
Aug 29, 2023
|
|
Pull Request Test Coverage Report for Build 6014844995
💛 - Coveralls |
|
@mgorny You will need to agree to the CLA here in qiskit-community organization too |
|
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the numpy version check in the test suite to account for the possibility that
numpy.__version__may contain letters.Details and comments
Prior to this change, running tests on numpy 1.26.0b1 would result in the following error:
Since the third component is matched against zero, the simplest solution is to check only the first two components, since we can expect that the first two split elements will be integers.
This is synced from the equivalent qiskit change:
Qiskit/qiskit#10723